feat: show googly eyes 👀 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
frontend
It would still be good to see the direction of the train still, so maybe we can do something like this where we show the googly eyes off to the side in the top right pill. That way we don't need a new tab for it and can show it on all the tabs |
|
@devinmatte I like that idea! I still think the tab should be here though, since there are so few of these cars that they can get lost on the default views. Let me try rendering a pill |
|
how does this look? I could pick a different color but you get the idea
|
|
That's solid, that's what I was thinking |
skaplan-dev
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
👀show the trains with googly eyes
https://apnews.com/article/boston-subway-trains-googly-eyes-42c69329096151eba01dc5b31f34fedc
Changes
Testing Instructions
Look at trains and verify that the cars with confirmed googly eyes show up with the eyes emoji. Let me know if there are any other cars I can add!