Fix permission errors when used with zsh-users/zsh-syntax-highlighting #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using this plugin alongside zsh-users/zsh-syntax-highlighting, pressing backspace or enter on an empty command line produces errors: - _zsh_highlight-zle-buffer-p:4: permission denied: - _zsh_highlight-zle-buffer:25: permission denied: - _zsh_highlight-zle-buffer:27: not an identifier: This happens because both plugins share internal arrays and the newer zsh-users plugin registers entries that are incompatible. Fix: - Validate highlight_predicate is non-empty before executing - Validate func exists as callable function before invoking - Validate cache_place is a valid identifier before assignment Builds on trapd00r#12 with additional guards. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Atyansh
force-pushed
the
fix-permission-errors
branch
from
9caf70b to
f1c1715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using this plugin alongside
zsh-users/zsh-syntax-highlighting, pressing backspace or enter on an empty command line produces errors like:_zsh_highlight-zle-buffer-p:4: permission denied:_zsh_highlight-zle-buffer:25: permission denied:_zsh_highlight-zle-buffer:27: not an identifier:This happens because both plugins share internal arrays (
zsh_highlight_functions,zsh_highlight_predicates,zsh_highlight_caches) and the newer zsh-users plugin registers entries that are incompatible with this plugin's expectations.Fix
$highlight_predicateis non-empty before executing it$funcexists as a callable function before invoking it$cache_placeis a valid identifier before using it in parameter assignmentBuilds on #12 with additional guards for the other affected code paths.
Testing
Tested with both plugins loaded via antigen on zsh 5.9. Backspace and enter on empty command line no longer produce errors.