-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Open Clover #120
base: master
Are you sure you want to change the base?
Conversation
e182eae
to
78af45b
Compare
After integrating this PR into my fork, I saw that there are test failures. any idea why? Do you still actively use this integration? |
@jwgmeligmeyling yes, we still actively use it, but we had to create a fork with the fix until this PR could be merged. @dogeared any idea? |
@trautonen what is necessary to get this merged? |
Hello @trautonen - I was looking to freshen this up. I thought I'd make a new branch off master and cherry pick my changes in. However, I am unable to build the project locally, currently. Here's what I'm getting:
And, without the Any guidance would be appreciated! |
Unfortunately, I also had no proper way to simulate the real environment used to build and publish this project yet. I'm looking forward that to try to bring this project from the grave. |
Yea, it could be that the checkstyle config is required from the etc project. But it would make sense to remove this submodule dependency completely and also change the build to github actions. I won't promise, but I'll try to spend some time end of this week to make this running again. |
Now that Atlassian has totally open-sourced clover, I wanted to add its support to this plugin.
I saw that you had a clover branch, but it's 3 years old and only seemed to be scaffolding anyway.