Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Open Clover #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dogeared
Copy link

@dogeared dogeared commented Sep 4, 2017

Now that Atlassian has totally open-sourced clover, I wanted to add its support to this plugin.

I saw that you had a clover branch, but it's 3 years old and only seemed to be scaffolding anyway.

@jwgmeligmeyling
Copy link

jwgmeligmeyling commented Apr 1, 2019

After integrating this PR into my fork, I saw that there are test failures. any idea why? Do you still actively use this integration?

@lhazlewood
Copy link

@jwgmeligmeyling yes, we still actively use it, but we had to create a fork with the fix until this PR could be merged. @dogeared any idea?

@lhazlewood
Copy link

@trautonen what is necessary to get this merged?

@dogeared
Copy link
Author

Hello @trautonen - I was looking to freshen this up. I thought I'd make a new branch off master and cherry pick my changes in.

However, I am unable to build the project locally, currently. Here's what I'm getting:

git submodule update
Cloning into '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: clone of 'git://github.com/trautonen/etc.git' into submodule path '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc' failed
Failed to clone 'etc'. Retry scheduled
Cloning into '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: clone of 'git://github.com/trautonen/etc.git' into submodule path '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc' failed
Failed to clone 'etc' a second time, aborting

And, without the etc submodule, mvn clean install fails.

Any guidance would be appreciated!

@PabloThiele
Copy link
Collaborator

Unfortunately, I also had no proper way to simulate the real environment used to build and publish this project yet. I'm looking forward that to try to bring this project from the grave.

@trautonen
Copy link
Owner

Yea, it could be that the checkstyle config is required from the etc project. But it would make sense to remove this submodule dependency completely and also change the build to github actions. I won't promise, but I'll try to spend some time end of this week to make this running again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants