Skip to content

Commit

Permalink
make all pointpillars use bug-fixed PFN
Browse files Browse the repository at this point in the history
  • Loading branch information
traveller59 committed May 9, 2019
1 parent 364c4bd commit 3aba19c
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion second/configs/nuscenes/all.pp.deprecated.config
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ model: {
max_number_of_points_per_voxel : 40
}
voxel_feature_extractor: {
module_class_name: "PillarFeatureNet"
module_class_name: "PillarFeatureNetOld"
num_filters: [64]
with_distance: false
num_input_features: 4
Expand Down
2 changes: 1 addition & 1 deletion second/configs/nuscenes/all.pp.largea.config
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ model: {
max_number_of_points_per_voxel : 60
}
voxel_feature_extractor: {
module_class_name: "PillarFeatureNetBugFix"
module_class_name: "PillarFeatureNet"
num_filters: [64]
with_distance: false
num_input_features: 4
Expand Down
2 changes: 1 addition & 1 deletion second/configs/nuscenes/all.pp.lowa.config
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ model: {
max_number_of_points_per_voxel : 60
}
voxel_feature_extractor: {
module_class_name: "PillarFeatureNetBugFix"
module_class_name: "PillarFeatureNet"
num_filters: [64]
with_distance: false
num_input_features: 4
Expand Down
2 changes: 1 addition & 1 deletion second/configs/nuscenes/all.pp.mida.config
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ model: {
height_threshold: 0.2 # locations with height < height_threshold will be removed.
}
voxel_feature_extractor: {
module_class_name: "PillarFeatureNet"
module_class_name: "PillarFeatureNetOld"
num_filters: [64]
with_distance: false
num_input_features: 4
Expand Down
16 changes: 8 additions & 8 deletions second/pytorch/models/pointpillars.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def forward(self, inputs):
return x_concatenated

@register_vfe
class PillarFeatureNet(nn.Module):
class PillarFeatureNetOld(nn.Module):
def __init__(self,
num_input_features=4,
use_norm=True,
Expand All @@ -86,14 +86,14 @@ def __init__(self,
"""

super().__init__()
self.name = 'PillarFeatureNet'
self.name = 'PillarFeatureNetOld'
assert len(num_filters) > 0
num_input_features += 5
if with_distance:
num_input_features += 1
self._with_distance = with_distance

# Create PillarFeatureNet layers
# Create PillarFeatureNetOld layers
num_filters = [num_input_features] + list(num_filters)
pfn_layers = []
for i in range(len(num_filters) - 1):
Expand Down Expand Up @@ -151,7 +151,7 @@ def forward(self, features, num_voxels, coors):
return features.squeeze()

@register_vfe
class PillarFeatureNetBugFix(nn.Module):
class PillarFeatureNet(nn.Module):
def __init__(self,
num_input_features=4,
use_norm=True,
Expand All @@ -172,14 +172,14 @@ def __init__(self,
"""

super().__init__()
self.name = 'PillarFeatureNet'
self.name = 'PillarFeatureNetOld'
assert len(num_filters) > 0
num_input_features += 5
if with_distance:
num_input_features += 1
self._with_distance = with_distance

# Create PillarFeatureNet layers
# Create PillarFeatureNetOld layers
num_filters = [num_input_features] + list(num_filters)
pfn_layers = []
for i in range(len(num_filters) - 1):
Expand Down Expand Up @@ -266,7 +266,7 @@ def __init__(self,
num_input_features += 1
self._with_distance = with_distance

# Create PillarFeatureNet layers
# Create PillarFeatureNetOld layers
num_filters = [num_input_features] + list(num_filters)
pfn_layers = []
for i in range(len(num_filters) - 1):
Expand Down Expand Up @@ -354,7 +354,7 @@ def __init__(self,
num_input_features += 1
self._with_distance = with_distance

# Create PillarFeatureNet layers
# Create PillarFeatureNetOld layers
num_filters = [num_input_features] + list(num_filters)
pfn_layers = []
for i in range(len(num_filters) - 1):
Expand Down

0 comments on commit 3aba19c

Please sign in to comment.