Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chat validation dueto Chat endpoint update #87

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

hieudion
Copy link
Contributor

@hieudion hieudion commented Oct 23, 2024

Zedesk has been updated the Chat domain from https://www.zopim.com/ to https://(subdomain).zendesk.com

https://support.zendesk.com/hc/en-us/articles/7827476398362-Deprecating-the-Zopim-Chat-REST-API-domain

We should remove the checking for the old one to improve the current connector

@hieudion hieudion requested a review from a team as a code owner October 23, 2024 03:18
Copy link
Contributor

@minidragon88 minidragon88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please help to update README and CHANGELOG afterward.
Thanks

@minidragon88 minidragon88 requested review from nmpennypacker and removed request for nmpennypacker October 23, 2024 03:27
@hieudion hieudion merged commit 1fb24b3 into master Oct 23, 2024
3 checks passed
@hieudion hieudion deleted the improve_chat_endpoint branch October 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants