Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embulk util retryhelper jetty version 94 #64

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Support embulk util retryhelper jetty version 94 #64

merged 1 commit into from
Apr 4, 2024

Conversation

vokhanhhuy
Copy link
Contributor

  • Upgrade jetty92 to jetty94 to suport TLS 1.3

@vokhanhhuy vokhanhhuy requested a review from a team as a code owner April 3, 2024 07:43
@vokhanhhuy vokhanhhuy requested a review from vietnguyen-td April 3, 2024 07:44
vietnguyen-td
vietnguyen-td approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@vietnguyen-td vietnguyen-td left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vietnguyen-td vietnguyen-td requested a review from a team April 3, 2024 07:47
nmpennypacker
nmpennypacker approved these changes Apr 3, 2024
View reviewed changes
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

@vokhanhhuy vokhanhhuy merged commit 9893745 into master Apr 4, 2024
1 check passed
@vokhanhhuy vokhanhhuy deleted the support_embulk-util-retryhelper-jetty_version_94 branch April 4, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietnguyen-td vietnguyen-td vietnguyen-td approved these changes

@nmpennypacker nmpennypacker nmpennypacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vokhanhhuy @nmpennypacker @vietnguyen-td