Merged
Conversation
chezou
reviewed
Sep 16, 2024
.github/workflows/test.yml
Outdated
| os: [ubuntu-latest, windows-latest] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | ||
| pandas-version: ["1.3.5", "1.4.4", "1.5.3", "2.2.2"] | ||
| pandas-version: ["1.3.5", "1.4.4", "1.5.3", "2.0.3", "2.1.4", "2.2.2"] |
Member
There was a problem hiding this comment.
I think testing over two versions would be enough, i.e., 1.5.3 and 2.2.2. Is there any specific reason to test for 1.3.5, 1.4.4, 2.0.3, and 2.1.4?
Contributor
Author
There was a problem hiding this comment.
No specific reason. I'm just following current convention (1.3, 1.4, 1.5)
If you think it's uneccessary, I'll test major versions only. I think testing minor version has limited benefit as well (unless there is some bug in one of pandas versions). Testing only 2 versions will drastically improve test time (now close to 1 hour 😬 )
Member
There was a problem hiding this comment.
Okay, then let's test 2 major versions only.
chezou
reviewed
Sep 17, 2024
Co-authored-by: Aki Ariga <ariga@treasure-data.com>
chezou
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of sanity tests I've done for pandas 2 support:
Setup
Upload to TD table
Results: table is successfully imported to TD
Query TD table
Result:
Read through pandas 2.0.0 release notes
https://pandas.pydata.org/docs/dev/whatsnew/v2.0.0.html
Seems like the only change that can potentially break backward compatibility is Construction with datetime64 or timedelta64 dtype with unsupported resolution
Currently, we only support datetime64[ns] for time column. In pandas 1, if pytd users specify a wrong resolution for datetime64, for example, datetime64[s], they can still convert and import the column correctly. But in pandas 2, they won't be able to convert and import the time column