Enable Multithreading on msgpack
Chunking in BulkImportWriter
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how multithreading is enabled on the
msgpack
temp file uploads - this PR enables multithreading in the chunking process itself, using the same number of max workers as the uploads.Benchmark Script
Script Results
Progress Bar - 100M rows
The script works nicely with the
show_progress
flag from #141 since it's easy to observe the individual steps.On
main
+feature/show_progress_bulk_import
:On
feature/multi_threaded_chunking
+feature/show_progress_bulk_import
:No Progress Bar - 1M rows
Without the progress bar, due to the variable bulk import times in the
performing a bulk import job
step, it's not as easy to observe the direct effect of the PR. One can only measure the end-to-end time holistically (confounding variable, i.e. the import time, is not accounted for).On
main
:On
feature/multi_threaded_chunking
:On my local environment:
P.S. Resulting table in the database seems to have no side effects. Double checking tomorrow morning with fresh eyes if everything is as it should be in the results.