Update response for database api #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnutz
force-pushed
the
update_response_for_database_api
branch
from
2a8f291 to
7930dc8
Compare
yuokada
reviewed
Jul 17, 2024
| @@ -30,6 +30,8 @@ public class TDDatabase | |||
| private final String id; | |||
| private final String name; | |||
| private final long count; | |||
| private final long userId; | |||
There was a problem hiding this comment.
In td-client-java, user_id is handled as an integer value as follows:
It's good to follow the existing data type for user_id as much as possible.
yuokada
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad
user_idanddescriptionto the response