-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Retry POST against 502, 503 and 504 responses #134
Open
kar0t
wants to merge
2
commits into
treasure-data:master
Choose a base branch
from
kar0t:1ambda-patch-trino-retry-50x-post
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: Retry POST against 502, 503 and 504 responses #134
kar0t
wants to merge
2
commits into
treasure-data:master
from
kar0t:1ambda-patch-trino-retry-50x-post
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kar0t
force-pushed
the
1ambda-patch-trino-retry-50x-post
branch
from
December 10, 2024 14:47
7e6ea27
to
67484cc
Compare
kar0t
force-pushed
the
1ambda-patch-trino-retry-50x-post
branch
from
December 10, 2024 14:47
67484cc
to
a2dc9e5
Compare
exoego
reviewed
Dec 12, 2024
exoego
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test.
trino-client-ruby/spec/statement_client_spec.rb
Lines 592 to 632 in 55c3bdc
it "raises TrinoQueryTimeoutError if timeout during execution" do | |
stub_request(:post, "localhost/v1/statement"). | |
with(body: query, headers: headers). | |
to_return(body: planning_response.to_json) | |
client = StatementClient.new(faraday, query, options.merge(query_timeout: 1)) | |
stub_request(:get, "localhost/v1/next_uri"). | |
with(headers: headers). | |
to_return(body: early_running_response.to_json) | |
client.advance | |
sleep 1 | |
stub_request(:get, "localhost/v1/next_uri"). | |
with(headers: headers). | |
to_return(body: late_running_response.to_json) | |
expect do | |
client.advance | |
end.to raise_error(Trino::Client::TrinoQueryTimeoutError, "Query queryid timed out") | |
end | |
it "doesn't raise errors if query is done" do | |
stub_request(:post, "localhost/v1/statement"). | |
with(body: query, headers: headers). | |
to_return(body: planning_response.to_json) | |
client = StatementClient.new(faraday, query, options.merge(query_timeout: 1)) | |
stub_request(:get, "localhost/v1/next_uri"). | |
with(headers: headers). | |
to_return(body: early_running_response.to_json) | |
client.advance | |
stub_request(:get, "localhost/v1/next_uri"). | |
with(headers: headers). | |
to_return(body: done_response.to_json) | |
client.advance # set finished | |
sleep 1 | |
client.advance # set finished | |
end |
I am writing a test for the modified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Retry POST against 50X responses.
Here's what I'd like to see reviewed
faraday_get_with_retry
as much as possible.Overview
According to the trino client protocol, it should also retry for POST.
Checklist