Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support disjunctive normal form types #203

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

calebdw
Copy link
Collaborator

@calebdw calebdw commented Jan 5, 2024

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (2 new conflicts)
  • The parser size hasn't grown too much (master: 2654, PR: 2689)
    (check the value of STATE_COUNT in src/parser.c)

Hello!

This adds support for DNF types and subsequently closes #139 (note that this is branched from #192).

Thanks!

@calebdw calebdw force-pushed the dnf_types branch 2 times, most recently from 36404bd to 428bcc8 Compare January 6, 2024 14:30
@cfroystad
Copy link
Collaborator

This is very nice work!

@maxbrunsfeld May I suggest giving @calebdw commit access so that he may merge simple PRs without waiting too long for the rest of us to find the time?

@cfroystad cfroystad merged commit 0d931c1 into tree-sitter:master Jan 23, 2024
4 checks passed
@calebdw calebdw deleted the dnf_types branch January 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PHP 8.2
2 participants