Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dynamic class constant fetch #207

Closed
wants to merge 1 commit into from

Conversation

calebdw
Copy link
Collaborator

@calebdw calebdw commented Jan 5, 2024

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (x new conflicts)
  • The parser size hasn't grown too much (master: STATE_COUNT, PR: STATE_COUNT)
    (check the value of STATE_COUNT in src/parser.c)

Hello!

This adds support for dynamic class constant fetch---subsequently closes #197 after #205 is merged. (note this is branched from #192).

I went ahead and kept the same class_constant_access_expression node...I'm not sure if we need a separate dynamic node.

Thanks!

@calebdw calebdw force-pushed the dynamic_const_fetch branch 2 times, most recently from e0c5bd9 to 839246d Compare January 6, 2024 14:33
@calebdw calebdw force-pushed the dynamic_const_fetch branch from 839246d to ea29f11 Compare January 13, 2024 05:08
@calebdw calebdw force-pushed the dynamic_const_fetch branch 3 times, most recently from a8c25c2 to 1100478 Compare January 25, 2024 18:34
@calebdw calebdw force-pushed the dynamic_const_fetch branch from 1100478 to fab0c75 Compare January 25, 2024 18:47
@calebdw calebdw mentioned this pull request Jan 26, 2024
5 tasks
@calebdw
Copy link
Collaborator Author

calebdw commented Jan 26, 2024

See #214

@calebdw calebdw closed this Jan 26, 2024
@calebdw calebdw deleted the dynamic_const_fetch branch January 26, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support php 8.3
1 participant