Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error when string contains php closing tag #222

Merged
merged 4 commits into from
Feb 21, 2024
Merged

fix: error when string contains php closing tag #222

merged 4 commits into from
Feb 21, 2024

Conversation

calebdw
Copy link
Collaborator

@calebdw calebdw commented Feb 20, 2024

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (0 rules renamed)
  • The conflicts section hasn't grown too much (0 new conflicts)
  • The parser size hasn't grown too much (master: 2713, PR: 2711)
    (check the value of STATE_COUNT in src/parser.c)

Closes #221

@cfroystad
Copy link
Collaborator

Very nice! Thanks for both fixing and cleaning this up!

@cfroystad cfroystad merged commit 710754c into tree-sitter:master Feb 21, 2024
4 checks passed
@calebdw calebdw deleted the end_tag_in_string branch February 21, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse error for string ends with "?>"
2 participants
@calebdw @cfroystad