Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <div className="flex-1 min-w-0"> | ||
| <button | ||
| onClick={() => handleProfileClick(post.author)} | ||
| onClick={() => handleBlogMainClick(post.username)} |
There was a problem hiding this comment.
handleProfileClick 함수 대신 handleBlogMainClick 함수를 사용하는 것으로 변경되었는데, post.author 대신 post.username을 사용하는 이유에 대한 명확한 설명이 필요합니다. 두 변수의 의미 차이와 이 변경이 의도하는 바를 코드 주석이나 commit message에 명확히 기재해야 합니다. 만약 author 필드가 더 이상 사용되지 않는다면, post 객체에서 해당 필드를 제거하는 것을 고려해볼 수 있습니다. 또한, handleBlogMainClick 함수의 구현 내용도 검토하여 예상치 못한 동작이 없는지 확인해야 합니다. handleProfileClick 함수와의 차이점을 명확히 이해하고 변경 사항을 검토해야 합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ test ] : #434 팝업창 바로가기 수정