Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add describeAvailabilityZones and gradle.properties for jvm heap size #39

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

Davinder2me
Copy link
Contributor

Add describeAvailabilityZones and gradle.properties for jvm heap size.

For large number of instances: jetty failed. Do you have fix that? By Adding the gradle jvm heap size helped little. However, still, it is still failing large numbers of instances

@maxiaohao maxiaohao merged commit 9fb6f3f into treelogic-swe:master Dec 9, 2016
@maxiaohao
Copy link
Member

maxiaohao commented Dec 9, 2016

Hi,
Thanks for the cool PR - I've reviewed it and merged it.
On the large number of inst failure, I think it relates to the thread model per instance - see class AbstractMockEc2Instance, which makes use of java.util.Timer. That means every mock EC2 instance runs in a separate jvm thread, which consumes considerable amount of resources and large number of threads could easily fail the jvm.
So I think, if possible, we may need to explore further options that can substitute the current java.util.Timer based model and have the performance improved. (actually I had such a plan earlier).
I am still too busy to look into this interesting issue and if you can do that, that would be great!
And I may have a chance to dip into that next weekend.

Thank you!

@Davinder2me
Copy link
Contributor Author

Hi,

Thanks for merging my pull request. However on large number of instances, I tried with ExecutorService instance of Timer, that did not help. However by changing heap size, i can create 30 K instances from earlier 5 K. Issue look like related to ThreadCount or File Count that OS can support.

I will try to see if we can improve that number to 50K.

Thanks
Davinder

@maxiaohao
Copy link
Member

maxiaohao commented Dec 11, 2016

That's great!
And I've filed that in the new issue #40 and let's try to get it improved.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants