Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with puppet-network #24

Closed
wants to merge 11 commits into from
Closed

Conversation

pedmon
Copy link
Contributor

@pedmon pedmon commented Dec 12, 2023

See the same issue in the Infiniband modue: treydock/puppet-infiniband#35 Below is not a fix but rather a start to one. Unfortunately the current puppet-network module (https://forge.puppet.com/modules/puppet/network) does not have the fields necessary to make this work yet. My question is how do you want to proceed?

@pedmon
Copy link
Contributor Author

pedmon commented Dec 13, 2023

I found a way in puppet-network to pass arbitrary variables. I think this should cover most of it.

@treydock
Copy link
Owner

These places need updates:

network:
repo: https://github.com/example42/puppet-network.git
ref: v3.6.1

"name": "example42/network",
"version_requirement": ">= 3.0.0 <4.0.0"

@pedmon
Copy link
Contributor Author

pedmon commented Jan 12, 2024

I've made the requested changes. I saw that you just committed a host of other changes but it looks like these are mutually exclusive. Still let me know if you need me to tweak anything else.

@treydock
Copy link
Owner

treydock commented Oct 7, 2024

Replaced by #26

@treydock treydock closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants