Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GoByte(GBX) support #695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add GoByte(GBX) support #695

wants to merge 2 commits into from

Conversation

erfan007p
Copy link

This PR adds support for the GoByte into Blockbook.

Coin information

Blockbook server

@martinboehm
Copy link
Contributor

Hi, the following tests are failing:

--- FAIL: TestGetAddrDescFromAddress (0.00s)
    --- FAIL: TestGetAddrDescFromAddress/P2PKH (0.00s)
        gobyteparser_test.go:171: GetAddrDescFromAddress() = 76a914ed22e769238dd0f934eea51073629f92dcc28af688ac, want 6e535552456f35544a356457716b336b644d48416343446863745353774754715962
    --- FAIL: TestGetAddrDescFromAddress/P2PKH#01 (0.00s)
        gobyteparser_test.go:171: GetAddrDescFromAddress() = 76a914e8d55cde2e27389fdc8f04b831d59e39931f6f5c88ac, want 6e533566654e587844656a6674644a4b614777646566514d59786b635941686b6f74
--- FAIL: TestGetAddrDescFromVout (0.00s)
    --- FAIL: TestGetAddrDescFromVout/P2PK (0.00s)
        gobyteparser_test.go:209: GetAddrDescFromVout() = 76a914ed22e769238dd0f934eea51073629f92dcc28af688ac, want 6e535552456f35544a356457716b336b644d48416343446863745353774754715962
    --- FAIL: TestGetAddrDescFromVout/P2PK#01 (0.00s)
        gobyteparser_test.go:209: GetAddrDescFromVout() = 76a914e8d55cde2e27389fdc8f04b831d59e39931f6f5c88ac, want 6e533566654e587844656a6674644a4b614777646566514d59786b635941686b6f74
--- FAIL: TestGetAddressesFromAddrDesc (0.00s)
    --- FAIL: TestGetAddressesFromAddrDesc/P2PKH (0.00s)
        gobyteparser_test.go:247: GetAddressesFromAddrDesc() error = opcode OP_DATA_69 requires 70 bytes, but script only has 30 remaining, wantErr false
    --- FAIL: TestGetAddressesFromAddrDesc/P2PKH#01 (0.00s)
        gobyteparser_test.go:247: GetAddressesFromAddrDesc() error = opcode OP_DATA_53 requires 54 bytes, but script only has 32 remaining, wantErr false
FAIL
FAIL	github.com/trezor/blockbook/bchain/coins/gobyte	0.064s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants