boot command/args refactoring #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: do not merge this before we tag BL 2.1.4 |
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
from
18a9f68
to
e7fee67
Compare
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
from
e7fee67
to
b66856a
Compare
cepetr
force-pushed
the
cepetr/bootargs
branch
from
db8a503
to
ac396f3
Compare
matejcik
reviewed
Nov 3, 2023
|
|
||
| // The 'g_boot_command_shadow' shadows a real boot command passed | ||
| // to the bootloader. | ||
| // 1. In the bootloader, it's value is set in the startup code. |
There was a problem hiding this comment.
typo
Suggested change
| // 1. In the bootloader, it's value is set in the startup code. | |
| // 1. In the bootloader, its value is set in the startup code. |
| @@ -21,7 +21,7 @@ async def reboot_to_bootloader(msg: RebootToBootloader) -> NoReturn: | |||
| # For convenience, we block unofficial firmwares from jumping to bootloader | |||
| # this way, so that the user doesn't get mysterious "install failed" errors. | |||
| # (It would be somewhat nicer if this was a compile-time flag, but oh well.) | |||
| is_official = utils.firmware_vendor() != "UNSAFE, DO NOT USE!" | |||
| is_official = True # utils.firmware_vendor() != "UNSAFE, DO NOT USE!" | |||
There was a problem hiding this comment.
this shoud not stay here of course
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
from
b66856a
to
8d78b28
Compare
TychoVrahe
reviewed
Nov 7, 2023
cepetr
force-pushed
the
cepetr/bootargs
branch
from
ac396f3
to
e8c4b3e
Compare
TychoVrahe
approved these changes
Nov 13, 2023
[no changelog]
cepetr
force-pushed
the
cepetr/bootargs
branch
from
d26260b
to
bb6f9d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored the boot command and arguments interface after merging the interaction-less update with the stm32u5 branch.
Passing and retrieving the reboot command and arguments should now be much clearer.