Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/ui): fix a few translation strings #4238

Merged
merged 5 commits into from
Oct 10, 2024
Merged

fix(core/ui): fix a few translation strings #4238

merged 5 commits into from
Oct 10, 2024

Conversation

obrusvit
Copy link
Contributor

@obrusvit obrusvit commented Oct 2, 2024 •
edited
Loading

PR contains:

  • a fix XPUB success screen title
  • a small fix of button labels
  • update of two IT/PT strings

@obrusvit obrusvit added the T3T1 label Oct 2, 2024
@obrusvit obrusvit self-assigned this Oct 2, 2024
@obrusvit obrusvit requested review from mmilata and removed request for prusnak October 2, 2024 10:18
@obrusvit obrusvit linked an issue Oct 2, 2024 that may be closed by this pull request
Receive address confirmed after xpub check #3947
Closed
@Hannsek
Copy link
Contributor

Hannsek commented Oct 2, 2024

Next time please fill in the details. 🙏🏻
image

@obrusvit obrusvit force-pushed the obrusvit/ui-mercury/xpub_success_title branch 3 times, most recently from 2de7d03 to 443373c Compare October 2, 2024 19:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@obrusvit obrusvit force-pushed the obrusvit/ui-mercury/xpub_success_title branch 2 times, most recently from 86445fc to f5fe053 Compare October 8, 2024 08:43
@obrusvit obrusvit added the translations Put this label on a PR to run tests in all languages label Oct 8, 2024
@Hannsek
Copy link
Contributor

Hannsek commented Oct 9, 2024

@obrusvit can we merge this pls? 🙏🏻

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@obrusvit
Copy link
Contributor Author

@mmilata I updated the PR with more strings updates. Could you please review again?
@Hannsek I'll wait for CI and re-approve, then we can merge.

@obrusvit obrusvit changed the title fix(core/ui): fix title of XPUB success screen fix(core/ui): fix a few translation strings Oct 10, 2024
@obrusvit obrusvit force-pushed the obrusvit/ui-mercury/xpub_success_title branch from d9b371f to 22d1c11 Compare October 10, 2024 12:53
mmilata
mmilata approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obrusvit obrusvit merged commit 3f1d205 into main Oct 10, 2024
129 of 130 checks passed
@obrusvit obrusvit deleted the obrusvit/ui-mercury/xpub_success_title branch October 10, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@obrusvit obrusvit

Labels
T3T1 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Receive address confirmed after xpub check
3 participants
@obrusvit @Hannsek @mmilata