Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download and patch fw binaries on nixos #292

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

szymonlesisz
Copy link
Contributor

@szymonlesisz szymonlesisz commented Feb 27, 2025

i had it stashed for a while now and used it only locally

im running user-env natively on nixos and having some issues since the configuration changed

  1. dowloading binaries produces copies instead of override existing file. Wtih this fix it will skip dowloading
  2. patching binaries does not work, the process doesnt throw any error but patched binary cannot be started

@szymonlesisz
Copy link
Contributor Author

i believe that failing test is not related to my changes

@grdddj
Copy link
Contributor

grdddj commented Mar 3, 2025

i believe that failing test is not related to my changes

Right, the failure is known, and it comes from trezorlib - I am attempting to fix it here - trezor/trezor-firmware#4664

@grdddj grdddj self-requested a review March 3, 2025 10:19
Copy link
Contributor

@grdddj grdddj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful things, thanks!

@grdddj grdddj merged commit 2b6f3e8 into master Mar 3, 2025
1 check failed
@grdddj grdddj deleted the fix/nixos-bin-patch branch March 3, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants