Various pam changes #982
Merged
Various pam changes #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is redundant with the PamErrorType.
None of the uses remaining before this commit had anything to do with state not being complete.
All callers of close_session ignore errors anyway. Also change PamContext::close_session to prevent calling pam_close_session again if a previous explicit call to PamContext::close_session failed.
|
If you could also pick up #981 in this PR, that'd be great :-) |
squell
reviewed
Feb 5, 2025
bjorn3
force-pushed
the
various_pam_changes
branch
from
46294b8 to
bcb680d
Compare
squell
reviewed
Feb 5, 2025
Mostly copied from og sudo.
This case is only possible when there is a bug in sudo-rs and it is a fatal error anyway.
bjorn3
force-pushed
the
various_pam_changes
branch
from
bcb680d to
f543e67
Compare
squell
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
PamContextBuilderand some misc changes around PAM errors.