Skip to content

Next major release #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sh1sh4k1n9 wants to merge 201 commits into
base: master
Choose a base branch
from

fix: Small fixes

48cb96c
Select commit
Loading
Failed to load commit list.
Draft

Next major release #103

fix: Small fixes
48cb96c
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Oct 20, 2025 in 4s

8 issues fixed. 24 issues found. Autofix available.

Annotations

Check warning on line 208 in src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/StudentGroupServiceImpl.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/StudentGroupServiceImpl.kt#L208 

Parentheses in (s.task.id == task.id) are unnecessary and can be replaced with: s.task.id == task.id. (detekt.UnnecessaryParentheses)

Check notice on line 396 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperContestController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperContestController.kt#L314-L396 

Complex Method

Check warning on line 145 in src/main/kotlin/trik/testsys/webapp/backoffice/service/impl/FileManagerImpl.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/service/impl/FileManagerImpl.kt#L145 

Forbidden TODO todo marker in comment, please do the changes. (detekt.ForbiddenComment)

Check warning on line 17 in src/main/kotlin/trik/testsys/webapp/grading/BalancingUtils.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/grading/BalancingUtils.kt#L17 

Parentheses in (status as? Grader.NodeStatus.Alive) are unnecessary and can be replaced with: status as? Grader.NodeStatus.Alive. (detekt.UnnecessaryParentheses)

Check warning on line 16 in src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/SolutionServiceImpl.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/SolutionServiceImpl.kt#L16 

Unnecessary block ("{}") (detekt.NoEmptyClassBody)

Check warning on line 233 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperTaskController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperTaskController.kt#L233 

Parentheses in (s.id!!) are unnecessary and can be replaced with: s.id!! (detekt.UnnecessaryParentheses)

Check warning on line 208 in src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/StudentGroupServiceImpl.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/StudentGroupServiceImpl.kt#L208 

Parentheses in (s.contest?.id == contest.id) are unnecessary and can be replaced with: s.contest?.id == contest.id. (detekt.UnnecessaryParentheses)

Check warning on line 19 in src/main/kotlin/trik/testsys/webapp/backoffice/utils/handler/GradingSystemErrorHandler.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/utils/handler/GradingSystemErrorHandler.kt#L19 

Parentheses in (httpResponse.statusCode.is4xxClientError || httpResponse.statusCode.is5xxServerError) are unnecessary and can be replaced with: httpResponse.statusCode.is4xxClientError || httpResponse.statusCode.is5xxServerError. (detekt.UnnecessaryParentheses)

Check warning on line 199 in src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/StudentGroupServiceImpl.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/data/service/impl/StudentGroupServiceImpl.kt#L199 

Parentheses in (admin?.name ?: "") are unnecessary and can be replaced with: admin?.name ?: "". (detekt.UnnecessaryParentheses)

Check warning on line 73 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt#L73 

Parentheses in (s.id!!) are unnecessary and can be replaced with: s.id!! (detekt.UnnecessaryParentheses)

Check warning on line 119 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/student/StudentContestsController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/student/StudentContestsController.kt#L119 

Parentheses in (totalSeconds % 3600) are unnecessary and can be replaced with: totalSeconds % 3600. (detekt.UnnecessaryParentheses)

Check warning on line 57 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/MainController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/MainController.kt#L57 

Parentheses in (request.getAttribute("accessToken") as? String) are unnecessary and can be replaced with: request.getAttribute("accessToken") as? String. (detekt.UnnecessaryParentheses)

Check warning on line 122 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/student/StudentContestController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/student/StudentContestController.kt#L122 

Parentheses in (totalSeconds % 3600) are unnecessary and can be replaced with: totalSeconds % 3600. (detekt.UnnecessaryParentheses)

Check warning on line 12 in src/main/kotlin/trik/testsys/webapp/backoffice/data/repository/SolutionRepository.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/data/repository/SolutionRepository.kt#L12 

Unnecessary block ("{}") (detekt.NoEmptyClassBody)

Check warning on line 10 in src/main/kotlin/trik/testsys/webapp/backoffice/data/service/SolutionService.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/data/service/SolutionService.kt#L10 

Unnecessary block ("{}") (detekt.NoEmptyClassBody)

Check warning on line 46 in src/main/kotlin/trik/testsys/webapp/grading/communication/GraderClient.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/grading/communication/GraderClient.kt#L46 

Forbidden TODO todo marker in comment, please do the changes. (detekt.ForbiddenComment)

Check warning on line 67 in src/main/kotlin/trik/testsys/webapp/backoffice/data/entity/impl/Contest.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/data/entity/impl/Contest.kt#L67 

Parentheses in (++idx) are unnecessary and can be replaced with: ++idx. (detekt.UnnecessaryParentheses)

Check warning on line 90 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/student/StudentTaskController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/student/StudentTaskController.kt#L90 

Parentheses in (s.id!!) are unnecessary and can be replaced with: s.id!! (detekt.UnnecessaryParentheses)

Check notice on line 506 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperContestController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperContestController.kt#L431-L506 

Complex Method

Check warning on line 979 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperTaskController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperTaskController.kt#L979 

Private class TaskFileListItem is unused. (detekt.UnusedPrivateClass)

Check warning on line 140 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt#L140 

Parentheses in (fileManager.getSolution(solution) != null) are unnecessary and can be replaced with: fileManager.getSolution(solution) != null. (detekt.UnnecessaryParentheses)

Check warning on line 77 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt#L77 

Parentheses in (s.id!!) are unnecessary and can be replaced with: s.id!! (detekt.UnnecessaryParentheses)

Check warning on line 249 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperTaskController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/developer/DeveloperTaskController.kt#L249 

Parentheses in (s.id!!) are unnecessary and can be replaced with: s.id!! (detekt.UnnecessaryParentheses)

Check warning on line 139 in src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/main/kotlin/trik/testsys/webapp/backoffice/controller/impl/user/judge/JudgeController.kt#L139 

Parentheses in (fileManager.getVerdicts(solution).isNotEmpty() || fileManager.getRecording(solution).isNotEmpty()) are unnecessary and can be replaced with: fileManager.getVerdicts(solution).isNotEmpty() || fileManager.getRecording(solution).isNotEmpty() (detekt.UnnecessaryParentheses)
View more details on codefactor.io