Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: ed25519 signing should hash input #54

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

emturner
Copy link
Collaborator

@emturner emturner commented Dec 14, 2023

fixes #44

See https://gitlab.com/tezos/tezos/-/merge_requests/11286 for corresponding fix in TX_KERNEL

@emturner emturner marked this pull request as ready for review December 14, 2023 12:29
@emturner emturner added the bug Something isn't working label Dec 14, 2023
@linoscope
Copy link

LGTM

@emturner emturner merged commit d15ccf0 into master Dec 14, 2023
7 checks passed
@emturner emturner deleted the emturner@tz1-hash-before-signing branch December 14, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecretKeyEd25519.sign should hash before signing
2 participants