Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding: support Ed25519Signature #57

Merged
merged 1 commit into from
Dec 18, 2023
Merged

encoding: support Ed25519Signature #57

merged 1 commit into from
Dec 18, 2023

Conversation

emturner
Copy link
Collaborator

@emturner emturner commented Dec 15, 2023 •
edited
Loading

fixes #36

@emturner emturner force-pushed the emturner@ed25519-sig-encoding branch from 759ddd9 to a2e4a0d Compare December 15, 2023 15:00
@emturner emturner force-pushed the emturner@ed25519-sig-encoding branch 3 times, most recently from 55d173a to 74d2a51 Compare December 18, 2023 11:26
lierdakil
lierdakil approved these changes Dec 18, 2023
View reviewed changes
Copy link

@lierdakil lierdakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emturner emturner merged commit 6e33a91 into master Dec 18, 2023
7 checks passed
@emturner emturner deleted the emturner@ed25519-sig-encoding branch December 18, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lierdakil lierdakil lierdakil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tezos_data_encoding: missing NomReader impl for Ed25519Signature
2 participants
@emturner @lierdakil