Cast port to intrger in connection options #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a Ruby test that asserts that establishing a connection with |
gmcgibbon
force-pushed
the
cast_connection_options
branch
from
3243f36
to
e7fc57f
Compare
Support string ports to make ENV config passing easier. Other gems like mysql2 support this use-case, so I think trilogy should too.
gmcgibbon
force-pushed
the
cast_connection_options
branch
from
e7fc57f
to
ce5b1cb
Compare
|
Ah, yeah good catch, removed! |
adrianna-chang-shopify
approved these changes
Jul 17, 2023
adrianna-chang-shopify
merged commit 61a8b40
into
trilogy-libraries:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support string ports to make ENV config passing easier. Other gems like mysql2 support this use-case (https://github.com/brianmario/mysql2/blob/master/lib/mysql2/client.rb#L92), so I think trilogy should too.