Report EOFError: TRILOGY_CLOSED_CONNECTION for SSL_ERROR_ZERO_RETURN #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a server closes the SSL connection cleanly (SSL_shutdown) as we
attempt a read or write (ie. a clean SSL shutdown but dirty MySQL
shutdown) we will get SSL_ERROR_ZERO_RETURN as the return code.
Previously we would have reported this as:
Trilogy::SSLError: trilogy_query_recv: SSL Error: (null)
Now it will be reported as:
Trilogy::EOFError: trilogy_query_recv: TRILOGY_CLOSED_CONNECTION
On older versions (< 2.5.0) we may also have reported this as
TRILOGY_CLOSED_CONNECTION.
Co-authored-by: Brendan Dougherty <b.w.dougherty@gmail.com>
composerinteralia
approved these changes
Oct 17, 2023
|
@jhawthorn Could I tempt you to release a new version with this fix included? |
Done in 2.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125
If a server closes the SSL connection cleanly (
SSL_shutdown) as we attempt a read or write (ie. a clean SSL shutdown but dirty MySQL shutdown) we will getSSL_ERROR_ZERO_RETURNas the return code.Previously we would have reported this as:
Now it will be reported as:
On older versions (< 2.5.0) we may also have been reporting this as
TRILOGY_CLOSED_CONNECTION.