Point mysql to certs instead of copying them #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngan
force-pushed
the
single-certs-dir
branch
3 times, most recently
from
6ee961a
to
7321988
Compare
ngan
commented
Apr 8, 2024
| @@ -35,6 +35,7 @@ output_fold() { | |||
| function cleanup() { | |||
| echo | |||
| echo "::group::Shutting down services..." | |||
| docker compose logs db | |||
There was a problem hiding this comment.
I added this because it helps a lot with debugging. It's a few extra log lines so figured we should just keep it instead of having to turn it on/off constantly.
ngan
changed the title
composerinteralia
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #175, I made it so that the certs were copied from
/var/lib/mysql/*.peminto/mysql-certs/*. This felt awkward at the time but I wanted to defer the fix since it wasn't that important. I'm revisit this now and in this PR, we're going to tell mysql where to find the certificates instead.This means that we now generate the certificates directly into
/mysql-certs/*-- so no more copying!