Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise MLFlow error when env TRITON_MODEL_REPO not set #7147

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JonasGoebel
Copy link

@JonasGoebel JonasGoebel commented Apr 22, 2024

This change adds an error message when the environment variable "TRITON_MODEL_REPO" is not set.
The previous error message (AttributeError: 'NoneType' object has no attribute 'startswith') was misleading and did not describe what is actually missing.

@rmccorm4 rmccorm4 changed the title added error message when env TRITON_MODEL_REPO not set Raise MLFlow error when env TRITON_MODEL_REPO not set May 24, 2024
@rmccorm4
Copy link
Collaborator

rmccorm4 commented May 24, 2024

Hi @JonasGoebel, thanks for the contribution!

Did you send a signed CLA per: https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla?

@JonasGoebel
Copy link
Author

Thank you for approval!
I just sent the signed CLA.

@JonasGoebel JonasGoebel requested a review from rmccorm4 June 4, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants