Remove unnecessary wait in case of failed stub creation #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
krishung5
requested changes
May 8, 2024
Tabrizian
reviewed
May 8, 2024
| faulty_model_name = "auto_complete_error" | ||
| with httpclient.InferenceServerClient(f"{_tritonserver_ipaddr}:8000") as client: | ||
| # Load a correct model | ||
| client.load_model(working_model_name) |
There was a problem hiding this comment.
Can you add a comment why a working model is required to reproduce the issue?
There was a problem hiding this comment.
I am still trying to figure this out.
I think we can merge this Test for 24.05 and meanwhile I will continue my investigation.
We have already merged the python backend change.
krishung5
previously approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new "Faulty" model to repro DLIS-5819 and cause the server to hang.
The test
The expectation is the server should NOT hang.