Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option to add model signature #7376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JonasGoebel
Copy link

What does the PR do?

This pull requests adds a signature option to log_model and save_model. Using this option, a MLflow signature can be added when uploading the model to the MLflow registry.
The parameter default is None so that the methods still work when no signature is given.

Before:
screenshot_without_signature

After:
screenshot_with_signature

Checklist

  • I have read the Contribution guidelines and signed the Contributor License
    Agreement
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

deploy/mlflow-triton-plugin/scripts/triton_flavor.py

Test plan:

Caveats:

Background

I want to use the MLflow Model input and output visualisation together with the triton flavor.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@JonasGoebel JonasGoebel marked this pull request as ready for review June 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant