This repository was archived by the owner on Mar 8, 2025. It is now read-only.
feat(bindings): Expose etcd functionality in python distributed runtime #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results61 tests 58 ✅ 7s ⏱️ For more details on these failures, see this check. Results for commit 87644d2. ♻️ This comment has been updated with latest results. |
ishandhanani
requested review from
nnshah1,
tanmayv25,
piotrm-nvidia,
ptarasiewiczNV,
nv-blazejkubiak,
ryanolson,
grahamking,
paulhendricks,
biswapanda,
tmonty12,
GuanLuo and
rmccorm4
as code owners
ishandhanani
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR exposes the EtcdClient functionality to Python bindings and updates the core.pyi file to reflect these changes. It enhances the capabilities of the DistributedRuntime by providing access to Etcd operations.
Detailed breakdown and reasoning
The addition of EtcdClient functionality allows Python users to interact with Etcd allowing us to leverage it for runtime discovery. Exposing this functionality will be helpful when it comes time to deploy NIXL on multiple nodes. As of now I have only exposed the
kv_create_or_validate,kv_put, andkv_get_prefixfunctionality.In future PRs, we can expose the watch functionality but it's not needed right now
Changes Made