Add dynamic dependency manager with relocation #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is extremely cursed... but it works!
|
Relevant stacktrace from the latest commit: https://paste.happyareabean.cc/syYLZQtb0e04a0W |
Add missing dependency on API.
diogotcorreia
added a commit
that referenced
this pull request
Jul 14, 2024
Due to #285, the TritonAPI class in the core module was no longer overshadowing the same class in the api module, effectively breaking the TritonAPI#getInstance method. This commit works around that by saving a reference to the Triton instance in the TritonAPI class ifself.
diogotcorreia
added a commit
that referenced
this pull request
Jul 14, 2024
Due to #285, the TritonAPI class in the core module was no longer overshadowing the same class in the api module, effectively breaking the TritonAPI#getInstance method. This commit works around that by saving a reference to the Triton instance in the TritonAPI class ifself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
Uses https://github.com/AlessioDP/libby as the dependency manager, which is based on LuckPerm's code.
Adventure itself is not relocated since we need to access native
Components on Paper and Velocity. If this turns out to be a problem in the future, we might consider using a converter, like LuckPerms has done.TODO:
libfolder on GitHub releases (as GitHub action)