add support for sceneSubBoundingRect and other functions requiring params, fix failing test on 12.5 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rams, fix failing test on 12.5
TwitchBronBron
approved these changes
Nov 17, 2023
| if RTA_isNode(callOn) then | ||
| return callOn.getParent() | ||
| else | ||
| RTA_logWarn("tried to call getParent() on non node of type " + type(callOn)) | ||
| end if | ||
| else if functionName = "count()" then | ||
| else if functionName = "count" then |
There was a problem hiding this comment.
I like seeing all the paren optimizations here.
| RTA_logWarn("tried to call sceneBoundingRect() on non node of type " + type(callOn)) | ||
| RTA_logWarn("tried to call sceneBoundingRect on non node of type " + type(callOn)) | ||
| end if | ||
| else if functionName = "sceneSubBoundingRect" then |
There was a problem hiding this comment.
Is there a way we could add better support for any function, rather than needing to hardcode specific functions? This list might become a bit unmanageable over time. Just curious.
There was a problem hiding this comment.
I believe that was one of the things Roku was asking us to rank. Currently there is no way to call a function from a param. I wouldn't be surprised if we never get it though as they use the fact that you have to use an exact string for a function call in their static analysis checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.