Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unused args #126

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Rename unused args #126

merged 3 commits into from
Feb 22, 2024

Conversation

iBicha
Copy link
Contributor

@iBicha iBicha commented Feb 21, 2024

Rename unused args to silence warnings

BRIGHTSCRIPT: WARNING: unused variable 'args' in function 'processgetallcountrequest' in pkg:/components/RTA_OnDeviceComponent.brs(552)
BRIGHTSCRIPT: WARNING: unused variable 'args' in function 'processgetrootscountrequest' in pkg:/components/RTA_OnDeviceComponent.brs(556)
BRIGHTSCRIPT: WARNING: unused variable 'request' in function 'processstopresponsivenesstestingrequest' in pkg:/components/RTA_OnDeviceComponent.brs(1138)
BRIGHTSCRIPT: WARNING: unused variable 'request' in function 'processgetresponsivenesstestingdatarequest' in pkg:/components/RTA_OnDeviceComponent.brs(1180)

Tagging unused variables (Available since Roku OS 11.0) – Variables can explicitly be marked as unused by prepending an underscore to the value (for example, sub myTask(_x)). This enables avoid compilation errors to occur when an unused variable, for example, has a special behavior or another valid purpose. Unused variables generate warnings that are output to the SceneGraph debug port (8085). The maximum number of warnings that may be generated is 100.

Copy link
Owner

@triwav triwav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iBicha for this. I left a couple suggestions since we pass request instead of args to each function.

iBicha and others added 2 commits February 22, 2024 11:30
Co-authored-by: Brian Leighty <bfleighty@gmail.com>
Co-authored-by: Brian Leighty <bfleighty@gmail.com>
@triwav triwav merged commit 4089a82 into triwav:master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants