-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2D Potential Temperature Formulation for the Euler Eqs. #38
base: main
Are you sure you want to change the base?
Add 2D Potential Temperature Formulation for the Euler Eqs. #38
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 81.78% 77.87% -3.91%
==========================================
Files 8 9 +1
Lines 829 1008 +179
==========================================
+ Hits 678 785 +107
- Misses 151 223 +72 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please add the new elixir to the tests so that the new code runs as well in CI?
Yep, thanks for the reminder! The test has been added now. |
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
This PR adds the Potential Temperature formulation for the Euler Eqs., where the energy equation has been substituted with the evolution of the potential temperature. The equations have been tested on the warm bubble dry test. The fluxes LMARS and an entropy conservative flux (total energy conserving) have been also added.