Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covariant form as variable-coefficient problem using auxiliary variables #47

Open
wants to merge 94 commits into
base: main
Choose a base branch
from

Conversation

tristanmontoya
Copy link
Member

This potentially replaces #31 by implementing the strategy described in #46, where the geometric information needed by covariant-form fluxes and source terms is passed in as auxiliary variables. The cache is not passed around anymore.

tristanmontoya and others added 30 commits July 18, 2024 21:57
…tion in Trixi.jl (cherry-picked from f45378e)

Co-authored-by: Tristan Montoya <montoya.tristan@gmail.com>
…ltype() and ndims() functions for new struct
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 98.50746% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (49ec206) to head (7e4a152).

Files with missing lines Patch % Lines
src/equations/shallow_water_3d.jl 90.47% 2 Missing ⚠️
...vers/dgsem_p4est/dg_2d_manifold_in_3d_covariant.jl 98.42% 2 Missing ⚠️
...em_p4est/containers_2d_manifold_in_3d_covariant.jl 98.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   84.71%   87.91%   +3.20%     
==========================================
  Files          11       17       +6     
  Lines        1125     1448     +323     
==========================================
+ Hits          953     1273     +320     
- Misses        172      175       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants