Skip to content

Improve test coverage#3

Merged
ranocha merged 4 commits intomainfrom
msl/improve-coverage
Jan 29, 2024
Merged

Improve test coverage#3
ranocha merged 4 commits intomainfrom
msl/improve-coverage

Conversation

@sloede
Copy link
Member

@sloede sloede commented Jan 29, 2024

@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf6528a) 88.52% compared to head (440a7d8) 93.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   88.52%   93.65%   +5.12%     
==========================================
  Files           4        4              
  Lines          61       63       +2     
==========================================
+ Hits           54       59       +5     
+ Misses          7        4       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member Author

sloede commented Jan 29, 2024

@ranocha
Copy link
Member

ranocha commented Jan 29, 2024

Your test file needs to look like

x = solve(maxiters = 123)

or

x = solve(; maxiters = 1234)

The position of the semicolon is important in the file included via trixi_include - not in the trixi_include command itself!

ranocha
ranocha previously approved these changes Jan 29, 2024
@ranocha ranocha merged commit 0e8161a into main Jan 29, 2024
@ranocha ranocha deleted the msl/improve-coverage branch January 29, 2024 15:41
@sloede
Copy link
Member Author

sloede commented Jan 29, 2024

I'm giving up... it seems like https://coveralls.io/builds/65357802/source?filename=src%2Ftrixi_include.jl#L81 is still not reached 😢.

Maybe some other day (or someone with more time and patience)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants