Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen #221: Transport Velocity for EDAC #436

Merged
merged 108 commits into from
Oct 30, 2024

Conversation

LasNikas
Copy link
Collaborator

@LasNikas LasNikas commented Mar 5, 2024

see #221
based on #440

Copy link
Collaborator

@svchb svchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation cases are not included in the CI Testing!

docs/src/systems/entropically_damped_sph.md Outdated Show resolved Hide resolved
src/schemes/fluid/entropically_damped_sph/system.jl Outdated Show resolved Hide resolved
src/schemes/fluid/transport_velocity.jl Outdated Show resolved Hide resolved
examples/fluid/periodic_array_of_cylinders_2d.jl Outdated Show resolved Hide resolved
examples/fluid/periodic_array_of_cylinders_2d.jl Outdated Show resolved Hide resolved
examples/fluid/periodic_array_of_cylinders_2d.jl Outdated Show resolved Hide resolved
examples/fluid/taylor_green_vortex_2d.jl Show resolved Hide resolved
test/schemes/fluid/transport_velocity.jl Outdated Show resolved Hide resolved
test/systems/edac_system.jl Show resolved Hide resolved
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the comment above.

efaulhaber
efaulhaber previously approved these changes Oct 29, 2024
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efaulhaber efaulhaber enabled auto-merge (squash) October 29, 2024 17:43
svchb
svchb previously approved these changes Oct 29, 2024
@svchb svchb dismissed stale reviews from efaulhaber and themself via b5e0e98 October 29, 2024 18:29
@efaulhaber efaulhaber merged commit ccd08be into trixi-framework:main Oct 30, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants