-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopen #363: Hydrostatic water column (FSI) #441
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 86 86
Lines 5261 5261
=======================================
Hits 3624 3624
Misses 1637 1637
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@efaulhaber and @svchb do we need this example or should I close this PR? |
I am fine with adding this example if the results are correct. |
What is this again? Was it the hydrostatic water column resting on an elastic beam? I'm against merging more examples that we don't really need. I prefer having useful validation examples from the literature only. Trixi.jl has too many examples, which makes it really hard for beginners. |
Niklas and I as far as I know are not against having as many examples as possible. But of course we would need to restructure the examples folder structure + docs page at some point. |
It's a validation example from Sun et al. (2019), as well as from O'Connor and Rogers (2021). |
Please add this as a comment and a description of what that simulation does. |
No description provided.