-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Particle Refinement: Split particles #650
Draft
LasNikas
wants to merge
27
commits into
trixi-framework:main
Choose a base branch
from
LasNikas:split-particles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,699
−347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efaulhaber
changed the title
Split particles
Adaptive Particle Refinement: Split particles
Nov 8, 2024
LasNikas
force-pushed
the
split-particles
branch
from
November 18, 2024 17:35
9e7d993
to
96b95bc
Compare
* change how adami pressure extrapolation is calculated and add optional offset * remove unused function * update * move to dispatch on function * fix * fix * format * fix test * format * change how adami pressure extrapolation is calculated and add optional offset * remove unused function * update * move to dispatch on function * fix * fix * format * fix test * format * fix merge * fix merge * fix * fix * fix * add new bnd density calculator * missing code * fix test * fix * fix * fix docs * fix * format * review comments * fix test * fix test * format * fix * update docs * fix * set test up for 1.11 * format * implement suggestions * fix equation * formatting * format * Increase errors for 1.11 * Fix invalidations * Fix tests * Update ci.yml * revert * Update ci.yml * Update test/validation/validation.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * review comments * adjust docs * adjust docs * format * add complete equation * Update docs/src/systems/boundary.md Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> --------- Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com>
* Test docs on win * Fix error on windows * Format * Update Documenter.yml * Update Documenter.yml
* Add docs for GPU support * Reformat code * Implement suggestions * Implement suggestions * Fix typo
* Avoid bounds checking where it is safe to do so * Avoid one more bounds check in density diffusion * Reformat code * Use `extract_svector` from PointNeighbors.jl * Revert 09ab7ba * Fix tests
* update docs intro * improve text consistency * Update docs/src/index.md Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Update README.md Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Update README.md * Update README.md * Update README.md * Update index.md * Update README.md Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update docs/src/index.md Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update docs/src/index.md Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update docs/src/index.md Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update README.md * Update README.md --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
* Replace hardcoded Float64 values * Avoid Float64 `eps()` * Remove the last Float64 occurrence in fluid-fluid kernel * Fix tests * Make all smoothing kernels preserve types and add test for this * Make eps(typeof(h)) consistent * Reformat code * Fix tests
* set test up for 1.11 * fix * typo * fix again * remove soundspeed from OBS * skip empty system * fix test * fix tests * fix tests * fix bug * fix * check dimensionality of reference functions * propagate characteristics * update * cleanup * update * Increase errors for 1.11 * Fix invalidations * Fix tests * Update ci.yml * revert * Update ci.yml * Update test/validation/validation.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * revert changes that had no benefit * update * cleanup * include in test run * remove redundancy * revert * fix tests * fix * fix test * fix test * fix the test * fix error * Update src/schemes/boundary/open_boundary/method_of_characteristics.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update test/schemes/boundary/open_boundary/boundary_zone.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update src/setups/extrude_geometry.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update src/schemes/boundary/open_boundary/method_of_characteristics.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update src/schemes/boundary/open_boundary/boundary_zones.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * Update examples/fluid/pipe_flow_3d.jl Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com> * fix test * fix test * format * fix test * format --------- Co-authored-by: LasNikas <niklas.neher@web.de> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
LasNikas
force-pushed
the
split-particles
branch
from
November 18, 2024 17:39
96b95bc
to
9462698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #648, #646, #644 and #649