[WIP] Shallow-water exner equations with wetting/drying#56
Draft
patrickersing wants to merge 1 commit intotrixi-framework:mainfrom
Draft
[WIP] Shallow-water exner equations with wetting/drying#56patrickersing wants to merge 1 commit intotrixi-framework:mainfrom
patrickersing wants to merge 1 commit intotrixi-framework:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 99.27% 96.28% -3.00%
==========================================
Files 61 63 +2
Lines 2630 2719 +89
==========================================
+ Hits 2611 2618 +7
- Misses 19 101 +82 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add wetting and drying for the
ShallowWaterExnerEquations1D, following the strategy used for the SWE.For the Exner equation drying is less problematic, as there is no separate velocity computation. For now there is no mechanism to ensure positive sediment height, so we need to assume that there is always some sediment present.
An open problem is that the hydrostatic reconstruction leads to continuous sediment height at interfaces and therefore removes any dissipation in the sediment layer, which leads to oscillations.
Furthermore, the sediment transport is very sensitive to velocity oscillations that might be present at/near the dry states.
Open problems: