Merge pull request #24 from yas-okadatech/update-to-apiv19

bump facebook sdk to 19.0.3
trocco-io · Aug 14, 2024 · 586b8bd · 586b8bd
2 parents 1145913 + 5499ff3
commit 586b8bd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/build.gradle b/build.gradle
@@ -1,5 +1,4 @@
 plugins {
-    id "com.jfrog.bintray" version "1.1"
     id "com.github.jruby-gradle.base" version "1.5.0"
     id "com.palantir.git-version" version "0.13.0"
     id "com.diffplug.spotless" version "5.15.0"
@@ -30,7 +29,7 @@ targetCompatibility = 1.8
 dependencies {
     compile  "org.embulk:embulk-core:0.9.17"
     provided "org.embulk:embulk-core:0.9.17"
-    compile group: "com.facebook.business.sdk", name: "facebook-java-business-sdk", version: "18.0.4"
+    compile group: "com.facebook.business.sdk", name: "facebook-java-business-sdk", version: "19.0.3"
     // compile "YOUR_JAR_DEPENDENCY_GROUP:YOUR_JAR_DEPENDENCY_MODULE:YOUR_JAR_DEPENDENCY_VERSION"
     testCompile "junit:junit:4.+"
 }
@@ -106,3 +105,15 @@ end
     }
 }
 clean { delete "${project.name}.gemspec" }
+
+sourceSets.all {
+    configurations.getByName(runtimeClasspathConfigurationName) {
+        attributes.attribute(Attribute.of("org.gradle.jvm.environment", String), "standard-jvm")
+    }
+    configurations.getByName(compileClasspathConfigurationName) {
+        attributes.attribute(Attribute.of("org.gradle.jvm.environment", String), "standard-jvm")
+    }
+    configurations.getByName(runtimeConfigurationName) {
+        attributes.attribute(Attribute.of("org.gradle.jvm.environment", String), "standard-jvm")
+    }
+}
diff --git a/src/main/java/org/embulk/input/facebook_ads_insights/AdsInsightsAccessor.java b/src/main/java/org/embulk/input/facebook_ads_insights/AdsInsightsAccessor.java
@@ -37,7 +37,6 @@ public String get(String name)
             case "adset_id": return adsInsights.getFieldAdsetId();
             case "adset_name": return adsInsights.getFieldAdsetName();
             case "adset_start": return adsInsights.getFieldAdsetStart();
-            case "age_targeting": return adsInsights.getFieldAgeTargeting();
             case "auction_bid": return adsInsights.getFieldAuctionBid();
             case "auction_competitiveness": return adsInsights.getFieldAuctionCompetitiveness();
             case "auction_max_competitor_bid": return adsInsights.getFieldAuctionMaxCompetitorBid();
@@ -77,24 +76,17 @@ public String get(String name)
             case "dda_countby_convs": return adsInsights.getFieldDdaCountbyConvs();
             case "engagement_rate_ranking": return adsInsights.getFieldEngagementRateRanking();
             case "estimated_ad_recall_rate": return adsInsights.getFieldEstimatedAdRecallRate();
-            case "estimated_ad_recall_rate_lower_bound": return adsInsights.getFieldEstimatedAdRecallRateLowerBound();
-            case "estimated_ad_recall_rate_upper_bound": return adsInsights.getFieldEstimatedAdRecallRateUpperBound();
             case "estimated_ad_recallers": return adsInsights.getFieldEstimatedAdRecallers();
-            case "estimated_ad_recallers_lower_bound": return adsInsights.getFieldEstimatedAdRecallersLowerBound();
-            case "estimated_ad_recallers_upper_bound": return adsInsights.getFieldEstimatedAdRecallersUpperBound();
             case "frequency": return adsInsights.getFieldFrequency();
             case "full_view_impressions": return adsInsights.getFieldFullViewImpressions();
             case "full_view_reach": return adsInsights.getFieldFullViewReach();
-            case "gender_targeting": return adsInsights.getFieldGenderTargeting();
             case "impressions": return adsInsights.getFieldImpressions();
             case "inline_link_click_ctr": return adsInsights.getFieldInlineLinkClickCtr();
             case "inline_link_clicks": return adsInsights.getFieldInlineLinkClicks();
             case "inline_post_engagement": return adsInsights.getFieldInlinePostEngagement();
             case "instant_experience_clicks_to_open": return adsInsights.getFieldInstantExperienceClicksToOpen();
             case "instant_experience_clicks_to_start": return adsInsights.getFieldInstantExperienceClicksToStart();
             case "instant_experience_outbound_clicks": return actionsToString(adsInsights.getFieldInstantExperienceOutboundClicks());
-            case "labels": return adsInsights.getFieldLabels();
-            case "location": return adsInsights.getFieldLocation();
             case "mobile_app_purchase_roas": return actionsToString(adsInsights.getFieldMobileAppPurchaseRoas());
             case "objective": return adsInsights.getFieldObjective();
             case "outbound_clicks": return actionsToString(adsInsights.getFieldOutboundClicks());