decrease memory utilization #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will measure memory utilization and upload results later 🙏 |
chikamura
reviewed
Jan 15, 2024
| } | ||
| } | ||
| } while (startDateTime != null && !startDateTime.isEmpty()); | ||
| lastRow.getChangeEvent().getChangeDateTime(); |
|
|
||
| response.iteratePages().iterator().forEachRemaining(pages::add); | ||
| public void search(Consumer<Iterable<GoogleAdsServiceClient.SearchPage>> consumer, Map<String, String> params) { |
There was a problem hiding this comment.
nits: Although Iterator is called twice to get the last row, it is called once when the search method params change to per page.
public void search(Consumer<GoogleAdsServiceClient.SearchPage> consumer, Map<String, String> params) {
Iterable<GoogleAdsServiceClient.SearchPage> pages = search(params);
for (GoogleAdsServiceClient.SearchPage page : pages) {
consumer.accept(page);
lastPage = page;
}
if (!task.getResourceType().equals("change_event") || lastPage == null) {
return;
}
...| lastRow.getChangeEvent().getChangeDateTime(); | ||
| Map<String, String> nextParams = new HashMap<>(); | ||
| nextParams.put("start_datetime", lastRow.getChangeEvent().getChangeDateTime()); | ||
| search(consumer, nextParams); |
There was a problem hiding this comment.
There is a risk that pages may not be released.
There was a problem hiding this comment.
fixed: 003f153
I fixed to pass single SearchPage to consumer, and pages is removed.
|
@chikamura I wrote about memory usage in the p-roverview, and fixed code. |
t3t5u
reviewed
Jan 17, 2024
| } | ||
| pageBuilder.flush(); | ||
| } | ||
| Map<String, String> params = new HashMap<>(); |
There was a problem hiding this comment.
NOTE:
Since params is empty, the initial value of start_datetime is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
to avoid oom error such as following.
it caused by iterate all pages and read result to memory. (implemented by #45)
embulk-input-google_ads/src/main/java/org/embulk/input/google_ads/GoogleAdsReporter.java
Line 72 in ababe29
running log
embulk config
Approximately 80,000 records can be retrieved under these config.yml in my env.
The following are the
jstatlog of the run with-J-Xmx400moptions.jstat(0.1.26)
When
S0,E, andOare reached 100%, OOM occured.jstat(this branch)