Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove unused columns" #29

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Revert "remove unused columns" #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ group = "com.treasuredata.embulk.plugins"
description = "Loads records from Marketo."
version = {
def baseVersion = "0.6.26"
def troccoVersion = "0.3.0"
def troccoVersion = "0.1.1"
def tag = "${baseVersion}-trocco-${troccoVersion}"
def vd = versionDetails()
if (vd.lastTag != "${tag}") {
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/embulk/input/marketo/delegate/ProgramInputPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,15 @@ public ServiceResponseMapper<? extends ValueLocator> buildServiceResponseMapper(
.add("description", Types.STRING)
.add("createdAt", Types.TIMESTAMP, MarketoUtils.MARKETO_DATE_TIME_FORMAT)
.add("updatedAt", Types.TIMESTAMP, MarketoUtils.MARKETO_DATE_TIME_FORMAT)
.add("startDate", Types.TIMESTAMP, MarketoUtils.MARKETO_DATE_TIME_FORMAT)
.add("endDate", Types.TIMESTAMP, MarketoUtils.MARKETO_DATE_TIME_FORMAT)
.add("url", Types.STRING)
.add("type", Types.STRING)
.add("channel", Types.STRING)
.add("folder", Types.JSON)
.add("status", Types.STRING)
.add("costs", Types.JSON)
.add("tags", Types.JSON)
.add("workspace", Types.STRING);
return builder.build();
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/embulk/input/marketo/delegate/ProgramInputPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@ private void testRun(ConfigSource config, Predicate<MarketoRestClient> expectedC
expectedCall.test(mockRestClient);

Schema embulkSchema = mapper.getEmbulkSchema();
// 13 columns
assertEquals(embulkSchema.size(), 13);
// 17 columns
assertEquals(embulkSchema.size(), 17);
// verify 3 times the method setLong for column id has been called
ArgumentCaptor<Long> longArgumentCaptor = ArgumentCaptor.forClass(Long.class);
Mockito.verify(mockPageBuilder, Mockito.times(3)).setLong(Mockito.eq(embulkSchema.lookupColumn("id")), longArgumentCaptor.capture());
Expand Down
Loading