fix: reconnect when auth error occurs in runDropStage method #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedPython
reviewed
Oct 24, 2024
| @@ -220,6 +231,35 @@ public ConfigDiff transaction( | |||
| return configDiff; | |||
| } | |||
|
|
|||
| private void runDropStage( | |||
There was a problem hiding this comment.
復帰処理も含んでのものだと思うので、名前に含んでおきたい気がしました
Suggested change
| private void runDropStage( | |
| private void runDropStageWithRecovery( |
yas-okadatech
force-pushed
the
24500-reconnect
branch
3 times, most recently
from
e994154 to
3dbaa10
Compare
yas-okadatech
force-pushed
the
24500-reconnect
branch
from
3dbaa10 to
f383ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If runCreateStage spent over 4 hours, auth might be expired.