troessner · mvz · Feb 17, 2025 · Dec 30, 2024 · Feb 17, 2025 · Feb 17, 2025
diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
@@ -23,7 +23,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby: ["3.0", "3.1", "3.2", "jruby-9.4", "3.3"]
+        ruby: ["3.1", "3.2", "jruby-9.4", "3.3", "3.4"]
 
     steps:
       - uses: actions/checkout@v4

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -12,7 +12,7 @@ AllCops:
   Exclude:
     - 'samples/**/*'
   NewCops: enable
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.1
 
 # Tables are nice
 Layout/HashAlignment:
@@ -84,13 +84,6 @@ RSpec/ExampleLength:
 Style/AndOr:
   EnforcedStyle: conditionals
 
-# Require comment for files in lib and bin
-Style/FrozenStringLiteralComment:
-  Include:
-    - 'bin/*'
-    - 'lib/**/*'
-  EnforcedStyle: always
-
 # Allow multiline block chains
 Style/MultilineBlockChain:
   Enabled: false

diff --git a/.simplecov b/.simplecov
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 SimpleCov.start do
   track_files 'lib/**/*.rb'
   add_filter 'lib/reek/version.rb' # version.rb is loaded too early to test

diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/clean'
 

diff --git a/docs/templates/default/docstring/setup.rb b/docs/templates/default/docstring/setup.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 def init
   super
   return unless show_api_marker_section?

diff --git a/docs/yard_plugin.rb b/docs/yard_plugin.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yard'
 
 # Template helper to modify processing of links in HTML generated from our

diff --git a/features/step_definitions/reek_steps.rb b/features/step_definitions/reek_steps.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 When /^I run reek (.*)$/ do |args|
   reek(args)
 end

diff --git a/features/step_definitions/sample_file_steps.rb b/features/step_definitions/sample_file_steps.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../samples/paths'
 
 Given(/^the smelly file '(.+)'$/) do |filename|

diff --git a/features/support/env.rb b/features/support/env.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../lib/reek'
 require_relative '../../lib/reek/cli/application'
 require 'aruba/cucumber'

diff --git a/lib/reek/context/code_context.rb b/lib/reek/context/code_context.rb
@@ -38,9 +38,9 @@ def initialize(exp)
       # @param type [Symbol] the type of the nodes we are looking for, e.g. :defs.
       # @yield block that is executed for every node.
       #
-      def local_nodes(type, ignored = [], &blk)
+      def local_nodes(type, ignored = [], &)
         ignored |= [:class, :module]
-        exp.each_node(type, ignored, &blk)
+        exp.each_node(type, ignored, &)
       end
 
       # Iterate over `self` and child contexts.

diff --git a/lib/reek/source/source_code.rb b/lib/reek/source/source_code.rb
@@ -75,11 +75,17 @@ def origin
 
       def code
         @code ||=
-          case source
-          when File, Pathname then source.read
-          when IO             then source.readlines.join
-          when String         then source
-          end.force_encoding(Encoding::UTF_8)
+          begin
+            str =
+              case source
+              when File, Pathname then source.read
+              when IO             then source.readlines.join
+              when String         then source
+              end
+
+            str = str.dup if str.frozen?
+            str.force_encoding(Encoding::UTF_8)
+          end
       end
 
       attr_reader :parser, :source

diff --git a/reek.gemspec b/reek.gemspec
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'lib/reek/version'
 
 Gem::Specification.new do |spec|
@@ -21,7 +23,7 @@ Gem::Specification.new do |spec|
 
   spec.executables = spec.files.grep(%r{^bin/}).map { |path| File.basename(path) }
   spec.rdoc_options = %w(--main README.md -x assets/|bin/|config/|features/|spec/|tasks/)
-  spec.required_ruby_version = '>= 3.0.0'
+  spec.required_ruby_version = '>= 3.1.0'
 
   spec.metadata = {
     'homepage_uri'          => 'https://github.com/troessner/reek',

diff --git a/spec/performance/reek/smell_detectors/runtime_speed_spec.rb b/spec/performance/reek/smell_detectors/runtime_speed_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../spec_helper'
 require_lib 'reek/examiner'
 

diff --git a/spec/quality/documentation_spec.rb b/spec/quality/documentation_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 require 'kramdown'
 

diff --git a/spec/quality/reek_source_spec.rb b/spec/quality/reek_source_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 
 RSpec.describe 'Reek source code' do

diff --git a/spec/reek/ast/node_spec.rb b/spec/reek/ast/node_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/ast/node'
 

diff --git a/spec/reek/ast/object_refs_spec.rb b/spec/reek/ast/object_refs_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/ast/object_refs'
 

diff --git a/spec/reek/ast/reference_collector_spec.rb b/spec/reek/ast/reference_collector_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/ast/reference_collector'
 

diff --git a/spec/reek/ast/sexp_extensions_spec.rb b/spec/reek/ast/sexp_extensions_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/ast/sexp_extensions'
 

diff --git a/spec/reek/cli/application_spec.rb b/spec/reek/cli/application_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/cli/application'
 

diff --git a/spec/reek/cli/command/report_command_spec.rb b/spec/reek/cli/command/report_command_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../spec_helper'
 require_lib 'reek/cli/command/report_command'
 require_lib 'reek/cli/options'

diff --git a/spec/reek/cli/command/todo_list_command_spec.rb b/spec/reek/cli/command/todo_list_command_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../spec_helper'
 require_lib 'reek/cli/command/todo_list_command'
 require_lib 'reek/cli/options'

diff --git a/spec/reek/cli/options_spec.rb b/spec/reek/cli/options_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/cli/options'
 

diff --git a/spec/reek/cli/silencer_spec.rb b/spec/reek/cli/silencer_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/cli/silencer'
 

diff --git a/spec/reek/code_climate/code_climate_configuration_spec.rb b/spec/reek/code_climate/code_climate_configuration_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/code_climate/code_climate_configuration'
 

diff --git a/spec/reek/code_climate/code_climate_fingerprint_spec.rb b/spec/reek/code_climate/code_climate_fingerprint_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/code_climate/code_climate_fingerprint'
 

diff --git a/spec/reek/code_climate/code_climate_formatter_spec.rb b/spec/reek/code_climate/code_climate_formatter_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/code_climate/code_climate_formatter'
 

diff --git a/spec/reek/code_climate/code_climate_report_spec.rb b/spec/reek/code_climate/code_climate_report_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/examiner'
 require_lib 'reek/code_climate'

diff --git a/spec/reek/code_comment_spec.rb b/spec/reek/code_comment_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 require_lib 'reek/code_comment'
 

diff --git a/spec/reek/configuration/app_configuration_spec.rb b/spec/reek/configuration/app_configuration_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pathname'
 require_relative '../../spec_helper'
 require_lib 'reek/configuration/app_configuration'

diff --git a/spec/reek/configuration/configuration_file_finder_spec.rb b/spec/reek/configuration/configuration_file_finder_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 require 'pathname'
 require 'tmpdir'

diff --git a/spec/reek/configuration/default_directive_spec.rb b/spec/reek/configuration/default_directive_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/configuration/default_directive'
 

diff --git a/spec/reek/configuration/directory_directives_spec.rb b/spec/reek/configuration/directory_directives_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/errors/config_file_error'
 require_lib 'reek/configuration/directory_directives'

diff --git a/spec/reek/configuration/excluded_paths_spec.rb b/spec/reek/configuration/excluded_paths_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/errors/config_file_error'
 require_lib 'reek/configuration/excluded_paths'

diff --git a/spec/reek/configuration/rake_task_converter_spec.rb b/spec/reek/configuration/rake_task_converter_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/configuration/rake_task_converter'
 

diff --git a/spec/reek/configuration/schema_spec.rb b/spec/reek/configuration/schema_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/configuration/schema'
 

diff --git a/spec/reek/configuration/schema_validator_spec.rb b/spec/reek/configuration/schema_validator_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/configuration/schema_validator'
 require_lib 'reek/errors/config_file_error'

diff --git a/spec/reek/context/code_context_spec.rb b/spec/reek/context/code_context_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/context/method_context'
 require_lib 'reek/context/module_context'

diff --git a/spec/reek/context/ghost_context_spec.rb b/spec/reek/context/ghost_context_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/context/code_context'
 require_lib 'reek/context/ghost_context'

diff --git a/spec/reek/context/method_context_spec.rb b/spec/reek/context/method_context_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/context/method_context'
 

diff --git a/spec/reek/context/module_context_spec.rb b/spec/reek/context/module_context_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/context/module_context'
 require_lib 'reek/context/root_context'

diff --git a/spec/reek/context/root_context_spec.rb b/spec/reek/context/root_context_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/context/root_context'
 

diff --git a/spec/reek/context/statement_counter_spec.rb b/spec/reek/context/statement_counter_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/context/statement_counter'
 

diff --git a/spec/reek/context_builder_spec.rb b/spec/reek/context_builder_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 require_lib 'reek/context_builder'
 

diff --git a/spec/reek/detector_repository_spec.rb b/spec/reek/detector_repository_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 require_lib 'reek/smell_detectors/base_detector'
 require_lib 'reek/detector_repository'

diff --git a/spec/reek/documentation_link_spec.rb b/spec/reek/documentation_link_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 
 RSpec.describe Reek::DocumentationLink do

diff --git a/spec/reek/errors/base_error_spec.rb b/spec/reek/errors/base_error_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 
 require_lib 'reek/errors/base_error'

diff --git a/spec/reek/examiner_spec.rb b/spec/reek/examiner_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 require_lib 'reek/examiner'
 require_lib 'reek/logging_error_handler'

diff --git a/spec/reek/logging_error_handler_spec.rb b/spec/reek/logging_error_handler_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 require_lib 'reek/logging_error_handler'
 

diff --git a/spec/reek/rake/task_spec.rb b/spec/reek/rake/task_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/rake/task'
 

diff --git a/spec/reek/report/github_report_spec.rb b/spec/reek/report/github_report_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/examiner'
 require_lib 'reek/report/json_report'

diff --git a/spec/reek/report/html_report_spec.rb b/spec/reek/report/html_report_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/examiner'
 require_lib 'reek/report/html_report'

diff --git a/spec/reek/report/json_report_spec.rb b/spec/reek/report/json_report_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/examiner'
 require_lib 'reek/report/json_report'

diff --git a/spec/reek/report/location_formatter_spec.rb b/spec/reek/report/location_formatter_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/report/location_formatter'
 

diff --git a/spec/reek/report/progress_formatter_spec.rb b/spec/reek/report/progress_formatter_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/report/progress_formatter'
 

diff --git a/spec/reek/report/text_report_spec.rb b/spec/reek/report/text_report_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/examiner'
 require_lib 'reek/report/text_report'

diff --git a/spec/reek/report/xml_report_spec.rb b/spec/reek/report/xml_report_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../spec_helper'
 require_lib 'reek/examiner'
 require_lib 'reek/report/xml_report'