Fix htonl on 64-bit values #1
Conversation
|
@troglobit As discussed via email, here is the PR for the bug. |
mping.c
Outdated
| if (debug) | ||
| { | ||
| struct mping packet; | ||
| printf("tv_sec size: %zu\n", sizeof(packet.tv.tv_sec)); | ||
| printf("tv_usec size: %zu\n", sizeof(packet.tv.tv_usec)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks like developer debug message, maybe we can do without it? Also, notice coding style (brace placement)
There was a problem hiding this comment.
I actually overlooked the brackets because they were different in the functions.
I have now corrected this and shortened the debug output to one line.
On modern systems, time values may be stored in a 64-bit integer. To send this over the network, it is necessary to package it appropriately. htonl is insufficient for this purpose, as it is limited to 32-bit values. See also https://stackoverflow.com/questions/3022552/is-there-any-standard-htonl-like-function-for-64-bits-integers-in-c Signed-off-by: Marek Küthe <m.k@mk16.de>
You can still do that. I just adopted the existing structure. |
Signed-off-by: Marek Küthe <m.k@mk16.de>
|
I have now extracted the network encoding code into two methods. If you would like it differently, you can just merge the first commit. |
2 participants
On modern systems, time values may be stored in a 64-bit integer. To send this over the network, it is necessary to package it appropriately. htonl is insufficient for this purpose, as it is limited to 32-bit values.
See also https://stackoverflow.com/questions/3022552/is-there-any-standard-htonl-like-function-for-64-bits-integers-in-c