Porting queue remediation: promote only build/run-verified containers and fix startup/build blockers

porting/queues/failing/freetube/Dockerfile

@@ -1,4 +1,4 @@
-FROM ghcr.io/trueforge-org/baseimage-kasmvnc:debianbookworm
+FROM containerforge/kasmvnc
 
 # set version label
 ARG VERSION

porting/queues/failing/series-troxide/Dockerfile

@@ -21,7 +21,7 @@ RUN \
   cargo install series-troxide
 
 # runtime
-FROM ghcr.io/trueforge-org/baseimage-kasmvnc:debianbookworm
+FROM containerforge/kasmvnc
 
 # set version label
 ARG VERSION

porting/queues/failing/tvheadend/Dockerfile

@@ -1,6 +1,6 @@
 ############## picons stage ##############
 # built by https://github.com/linuxserver/picons-builder
-FROM ghcr.io/trueforge-org/python:3.13.12
+FROM ghcr.io/trueforge-org/python:3.13.12 AS piconsstage
 
 
 FROM ghcr.io/trueforge-org/ubuntu:24.04 as buildstage

porting/queues/failing/dokuwiki/start.sh → porting/queues/passing/dokuwiki/start.sh

@@ -30,34 +30,36 @@ if [[ ! -d /config/dokuwiki/lib/images/smileys ]]; then
     mkdir -p /config/dokuwiki/lib/images/smileys/local
 fi
 
-## Move user folders to persistent storage
-for i in "${USER_DIRECTORY[@]}"; do
-    if [[ ! -d /config/dokuwiki/"${i}" ]] && [[ -d /app/www/public/"${i}" ]]; then
-        mv /app/www/public/"${i}" /config/dokuwiki/"${i}"/
-    fi
-done
-
-# Update built-in plugins
-for i in /app/www/public/lib/plugins/*/; do
-    if [[ -d "/config/dokuwiki/lib/plugins/$(basename "${i}")" ]] && [[ -d "/app/www/public/lib/plugins/$(basename "${i}")" ]] && [[ ! -L "/app/www/public/lib/plugins" ]]; then
-        cp -R /app/www/public/lib/plugins/"$(basename "${i}")"/* /config/dokuwiki/lib/plugins/"$(basename "${i}")"
-    fi
-done
-
-## Remove user folders
-for i in "${USER_DIRECTORY[@]}"; do
-    if [[ -d /app/www/public/"${i}" ]]; then
-        rm -rf /app/www/public/"${i}"
-    fi
-done
-
-## Make Symlinks
-for i in "${USER_DIRECTORY[@]}"; do
-    if [[ ! -L /app/www/public/"${i}" ]]; then
-        ln -s /config/dokuwiki/"${i}" /app/www/public/"${i}"
-    fi
-
-done
+if [[ -w /app/www/public ]]; then
+    ## Move user folders to persistent storage
+    for i in "${USER_DIRECTORY[@]}"; do
+        if [[ ! -d /config/dokuwiki/"${i}" ]] && [[ -d /app/www/public/"${i}" ]]; then
+            mv /app/www/public/"${i}" /config/dokuwiki/"${i}"/
+        fi
+    done
+
+    # Update built-in plugins
+    for i in /app/www/public/lib/plugins/*/; do
+        if [[ -d "/config/dokuwiki/lib/plugins/$(basename "${i}")" ]] && [[ -d "/app/www/public/lib/plugins/$(basename "${i}")" ]] && [[ ! -L "/app/www/public/lib/plugins" ]]; then
+            cp -R /app/www/public/lib/plugins/"$(basename "${i}")"/* /config/dokuwiki/lib/plugins/"$(basename "${i}")"
+        fi
+    done
+
+    ## Remove user folders
+    for i in "${USER_DIRECTORY[@]}"; do
+        if [[ -d /app/www/public/"${i}" ]]; then
+            rm -rf /app/www/public/"${i}"
+        fi
+    done
+
+    ## Make Symlinks
+    for i in "${USER_DIRECTORY[@]}"; do
+        if [[ ! -L /app/www/public/"${i}" ]]; then
+            ln -s /config/dokuwiki/"${i}" /app/www/public/"${i}"
+        fi
+
+    done
+fi
 
 ## Make Symlinks from /app/www/public to /config/dokuwiki
 ## This is to make sure plugins that include files
@@ -82,7 +84,7 @@ fi
 
 ## Remove install.php once setup & enable pretty urls to work after setting .htaccess method in admin panel.
 if [[ -f /config/dokuwiki/conf/local.php ]]; then
-    if rm -rf /app/www/public/install.php; then
+    if [[ -w /app/www/public ]] && rm -rf /app/www/public/install.php; then
         echo "Existing install found, deleting install.php."
     fi
 
@@ -100,4 +102,5 @@ fi
 ## Backwards compatibility 2021/04/15
 sed -i 's%location ~ /(conf/|bin/|inc/|install.php) { deny all; }%location ~ /(conf/|bin/|inc/|vendor/) { deny all; }%' /config/nginx/site-confs/default.conf
 
-## TODO: Missing exec
+cd /app/www/public
+exec php -S 0.0.0.0:8080

porting/queues/failing/emulatorjs/Dockerfile → porting/queues/passing/emulatorjs/Dockerfile

@@ -52,6 +52,7 @@ RUN \
 FROM ghcr.io/trueforge-org/node:22.22.0 as nodebuilder
 
 USER root
+ARG VERSION
 
 RUN \
   echo "**** install build packages ****" && \
@@ -110,17 +111,13 @@ RUN \
     file \
     flac \
     nginx \
+    nodejs \
     p7zip-full \
     python3 \
     libsdl2-2.0-0 && \
   apt-get install -y --no-install-recommends \
     mame-tools && \
-  mkdir /data && \
-  echo "**** use pinned node ****" && \
-  curl -L \
-    https://github.com/thelamer/node-stash/raw/master/v16.20.2/$TARGETARCH/node -o \
-    /bin/node && \
-  chmod +x /bin/node && \
+  mkdir -p /data && \
   echo "**** cleanup ****" && \
   rm -rf \
     /tmp/* && \

porting/queues/failing/emulatorjs/start.sh → porting/queues/passing/emulatorjs/start.sh

@@ -2,7 +2,7 @@
 
 
 # check if ipfs is disabled
-if [ -z ${DISABLE_IPFS+x} ]; then
+if [[ -z ${DISABLE_IPFS+x} ]] && command -v ipfs >/dev/null 2>&1; then
 
     # ipfs migrate check on startup
     if [[ -d "/data/.ipfs" ]]; then
@@ -17,7 +17,7 @@ if [ -z ${DISABLE_IPFS+x} ]; then
 fi
 
 # link user data to frontend
-if [[ ! -L '/emulatorjs/frontend/user' ]]; then
+if [[ -w '/emulatorjs/frontend' ]] && [[ ! -L '/emulatorjs/frontend/user' ]]; then
     ln -s /data /emulatorjs/frontend/user
 fi
 
@@ -34,7 +34,9 @@ if [[ ! -f '/config/profile/profile.json' ]]; then
 fi
 
 # nginx mime types
-cp /defaults/mime.types /etc/nginx/mime.types
+if [[ -w /etc/nginx ]]; then
+    cp /defaults/mime.types /etc/nginx/mime.types
+fi
 
 # allow users to mount in ro rom dirs
 DIRS='3do atari2600 atari5200 atari7800 colecovision doom gba lynx n64 nes odyssey2 psx segaCD segaMD segaSaturn snes vb ws arcade atari5200 gb gbc jaguar msx nds ngp pce sega32x segaGG segaMS segaSG vectrex'
@@ -70,4 +72,3 @@ cd /emulatorjs
 HOME=/config
 ## TODO: What to do with this?
 exec node profile.js
-

porting/queues/failing/flexget/start.sh → porting/queues/passing/flexget/start.sh

@@ -14,7 +14,7 @@ case "${FG_CONFIG_FILE}" in
   *yaml)
     FG_LOCK_FILE="${FG_CONFIG_FILE/config.yaml/.config-lock}"
     ;;
-  default)
+  *)
     echo "invalid config file extension"
     exit 1
     ;;
@@ -26,7 +26,7 @@ if [[ -f "${FG_LOCK_FILE}" ]]; then
 fi
 
 if [[ ! -f "${FG_CONFIG_FILE}" ]]; then
-    cp /default/config.yml "${FG_CONFIG_FILE}"
+    cp /root/default/config.yml "${FG_CONFIG_FILE}"
 fi
 
 if [[ -n "${FG_WEBUI_PASSWORD}" ]]; then
@@ -36,12 +36,6 @@ if [[ -n "${FG_WEBUI_PASSWORD}" ]]; then
     fi
 fi
 
-if grep -qe ' /data ' /proc/mounts; then
-
-        /data
-fi
-
 cd /config
 exec /app/venv/bin/python /app/venv/bin/flexget \
             --loglevel "${FG_LOG_LEVEL:-info}" --logfile "${FG_LOG_FILE:-/config/.flexget/flexget.log}" -c "${FG_CONFIG_FILE:-/config/.flexget/config.yml}" daemon start --autoreload-config
-