Skip to content

Conversation

@ixhamza
Copy link

@ixhamza ixhamza commented Oct 2, 2025

If zfs_mount_and_share() fails, the error propagates to zfs create/clone commands despite successful operation. If create/clone operations were successful, there's no point in making zfs_mount_and_share() failures fatal.

Reviewed-by: Brian Behlendorf behlendorf1@llnl.gov
Reviewed-by: Alexander Motin alexander.motin@TrueNAS.com
Closes openzfs#17799

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

If zfs_mount_and_share() fails, the error propagates to zfs create/clone
commands despite successful operation. If create/clone operations were
successful, there's no point in making zfs_mount_and_share() failures
fatal.

Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17799
@ixhamza ixhamza requested review from amotin and mgrimesix October 2, 2025 15:28
@ixhamza ixhamza added the jira label Oct 2, 2025
@bugclerk bugclerk changed the title Make mount/share errors non-fatal for zfs create/clone NAS-137845 / 26.04 / Make mount/share errors non-fatal for zfs create/clone Oct 2, 2025
@bugclerk
Copy link

bugclerk commented Oct 2, 2025

1 similar comment
@bugclerk
Copy link

bugclerk commented Oct 2, 2025

@ixhamza ixhamza merged commit 0981c67 into truenas/zfs-2.3-release Oct 2, 2025
34 of 44 checks passed
@ixhamza ixhamza deleted the fix-create-clone-exit-code-hm branch October 2, 2025 16:10
@bugclerk
Copy link

bugclerk commented Oct 2, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants