forked from agileworks-tw/sails-sample
-
Notifications
You must be signed in to change notification settings - Fork 11
week3 HW by Ken #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yoychen
wants to merge
4
commits into
trunk-studio:master
Choose a base branch
from
yoychen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,8 @@ sailsProject | |
|
|
||
| a [Sails](http://sailsjs.org) application | ||
|
|
||
| > 須使用 npm@3 安裝相依模組 | ||
|
|
||
| gem install | ||
| ----------- | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| module.exports = { | ||
| create: async (req, res) => { | ||
| try { | ||
| let friend = await Friend.create(req.body); | ||
| res.ok(friend); | ||
| } catch (e) { | ||
| res.serverError(e); | ||
| } | ||
| }, | ||
|
|
||
| findAll: async (req, res) => { | ||
| try { | ||
| let friends = await Friend.findAll(); | ||
| res.ok({friends}); | ||
| } catch (e) { | ||
| res.serverError(e); | ||
| } | ||
| }, | ||
|
|
||
| update: async (req, res) => { | ||
| try { | ||
| let result = await Friend.update(req.body,{ | ||
| where: { | ||
| id: req.params.id | ||
| } | ||
| }); | ||
| res.ok(result); | ||
| } catch (e) { | ||
| res.serverError(e); | ||
| } | ||
| }, | ||
|
|
||
| destroy: async (req, res) => { | ||
| try { | ||
| let result = await Friend.destroy({ | ||
| where: { | ||
| id: req.params.id | ||
| } | ||
| }); | ||
| res.ok(true); | ||
| } catch (e) { | ||
| res.serverError(e); | ||
| } | ||
| }, | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| module.exports = { | ||
| attributes: { | ||
| name: Sequelize.STRING, | ||
| email: Sequelize.STRING, | ||
| facebookId: Sequelize.INTEGER | ||
| }, | ||
| associations: function() { | ||
| }, | ||
| options: { | ||
| classMethods: {}, | ||
| instanceMethods: {}, | ||
| hooks: {} | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| describe('test Friend CRUD', () => { | ||
| let friendId = null; | ||
| before(async (done) => { | ||
| try { | ||
| const newFriend = { | ||
| name: 'wahaha', | ||
| email: 'wahaha@gm.com', | ||
| facebookId: '1234567' | ||
| }; | ||
| const result = await Friend.create(newFriend); | ||
| friendId = result.id; | ||
| done(); | ||
| }catch (e){ | ||
| done(); | ||
| } | ||
| }); | ||
|
|
||
| it('create a friend', async (done) => { | ||
| try{ | ||
| const newFriend = { | ||
| name: 'wahaha', | ||
| email: 'wahaha@gm.com', | ||
| facebookId: '1234567' | ||
| } | ||
| let res = await request(sails.hooks.http.app) | ||
| .post(`/friend/create`) | ||
| .send(newFriend).expect(200); | ||
| res.body.should.have.keys('id', 'name', 'email', 'facebookId', 'updatedAt', 'createdAt'); | ||
| done(); | ||
| }catch(e){ | ||
| done(); | ||
| } | ||
| }); | ||
|
|
||
| it('get friends', async (done) => { | ||
| try{ | ||
| let res = await request(sails.hooks.http.app).get(`/friend/find`).expect(200); | ||
| let {friends} = res.body; | ||
| friends.should.be.Array; | ||
| friends[0].should.have.keys('id', 'name', 'email', 'facebookId', 'updatedAt', 'createdAt'); | ||
| done(); | ||
| }catch(e){ | ||
| done(); | ||
| } | ||
| }); | ||
|
|
||
| it('update a friend', async (done) => { | ||
| try{ | ||
| let newInfo = { | ||
| name: 'haha' | ||
| } | ||
| let res = await request(sails.hooks.http.app) | ||
| .put(`/friend/update/${friendId}`) | ||
| .send(newInfo) | ||
| .expect(200); | ||
| res.body.should.be.Array; | ||
| res.body[0].should.be.eq(1); | ||
|
|
||
| let friend = await Friend.findById(friendId); | ||
| friend.name.should.be.eq('haha'); | ||
| done(); | ||
| }catch(e){ | ||
| done(); | ||
| } | ||
| }); | ||
|
|
||
| it('delete a friend', async (done) => { | ||
| try{ | ||
| let res = await request(sails.hooks.http.app) | ||
| .delete(`/friend/destroy/${friendId}`) | ||
| .expect(200); | ||
|
|
||
| let friend = await Friend.findById(friendId); | ||
| (friend === null).should.be.true; | ||
| done(); | ||
| }catch(e){ | ||
| done(); | ||
| } | ||
| }); | ||
|
|
||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果這邊 it.only 會錯吧?
要在 before 建立一個 friend 比較保險
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
還有我發現你的 測試裡面都沒
這樣子如果測試有寫錯會卡住